Sentora relying too much on Client data

[Droppy]

Hello dear community who are working all day for making a web a better place.

Basically is this: Sentora backend is relying (trusting) too much on frontend data to process requests and others.

Example of that is Email, example:

Create a new email account, but on domain you right click and select another domain which is pointed to your host.

Let's think about this schematics:

User 1's domains: abc.com , cde.com
User 2's domains: hax0r.com

User 2, wanting to sabotage User 1, discover that X domain is abc.com, and wants to create an email there (such as hacked@abc.com or hacked@cde.com), so user inspect element and changes values. Backend doesn't verify if the domain is from the user or not, it just clear the entrance, and the email is created.

There's other examples such as selecting subdomain and others, but it's the same concept.

Cya

[apinto]

Hello dear community who are working all day for making a web a better place.

Basically is this: Sentora backend is relying (trusting) too much on frontend data to process requests and others.

Example of that is Email, example:

Create a new email account, but on domain you right click and select another domain which is pointed to your host.

Let's think about this schematics:

User 1's domains: abc.com , cde.com
User 2's domains: hax0r.com

User 2, wanting to sabotage User 1, discover that X domain is abc.com, and wants to create an email there (such as hacked@abc.com or hacked@cde.com), so user inspect element and changes values. Backend doesn't verify if the domain is from the user or not, it just clear the entrance, and the email is created.

There's other examples such as selecting subdomain and others, but it's the same concept.

Cya

This is true.

Should be fixed.

[TGates]

Thanks for bringing this to our attention! We will look into it further.
5050 Me.B motters kandrews

[Me.B]

hmmm yep should be checked

[apinto]

The same is true for subdomains.

[elijahbate]

Hey all got a pr waiting to do the quick fix for the above listed errors should probably be merge asap.
https://github.com/sentora/sentora-core/pull/174

Elijah

[TGates]

I have merged the changes, but one of the devs will need to review it again before tagging it

[elijahbate]

I have merged the changes, but one of the devs will need to review it again before tagging it

Sweet as!
In the long run I think a fair bit of those modules could be rewritten for better validation and user experience

[bbspike]

One of the devs reviewed this?

[TGates]

5050 Me.B motters