This forum uses cookies
This forum makes use of cookies to store your login information if you are registered, and your last visit if you are not. Cookies are small text documents stored on your computer; the cookies set by this forum can only be used on this website and pose no security risk. Cookies on this forum also track the specific topics you have read and when you last read them. Please confirm whether you accept or reject these cookies being set.

A cookie will be stored in your browser regardless of choice to prevent you being asked this question again. You will be able to change your cookie settings at any time using the link in the footer.

The selected domain was not valid.
#1
[Not Solved] The selected domain was not valid.
Hello , did Zpanel upgrade to Sentoria , I had to create the db manually, but now I'm getting probelmas to create subdomains and email , with these errors :

Email:

Quote:The selected domain was not valid.

subdomains:


Quote:Your Domain name is not valid. Please enter a valid Domain Name: i.e. 'domain.com'


anyone have any idea?


Attached Files Thumbnail(s)
       
Reply
Thanks given by:
#2
[Not Solved] RE: The selected domain was not valid.
Upgrade tool is still beta.

kandrews
No support using PM (Auto adding to IGNORE list!), use the forum. 
How to ask
Coldfusion Freelance

10$ free to start your VPS

Reply
Thanks given by:
#3
[Not Solved] RE: The selected domain was not valid.
Same problem about sub-domaine, and i install from scratch and version 1.0.3

[Image: subdomain.jpg]
Reply
Thanks given by:
#4
[Not Solved] RE: The selected domain was not valid.
Same problem here
Reply
Thanks given by:
#5
[Not Solved] RE: The selected domain was not valid.
Me.B. Any ideas? This is becoming a recurring issue...
-TGates - Head of Support

SEARCH the Forums or read the DOCUMENTATION before posting!
Modules Maintained: 13 - Module Installs: 108k+

Find my support or modules helpful? Donate HERE
Get your domains using my affiliate link:
GoDaddy - Domains
Reply
Thanks given by:
#6
[Not Solved] RE: The selected domain was not valid.
It should not and this seem related to new installer post 1.0.3? Upgrade tool?

We are supposed in 1.0.3 to use OLD 1.0 panel code branch and only patching here the FTP issue.

So a bit surprising, I notice the issue firstly reported with upgrades from ZPANEL.
No support using PM (Auto adding to IGNORE list!), use the forum. 
How to ask
Coldfusion Freelance

10$ free to start your VPS

Reply
Thanks given by:
#7
[Not Solved] RE: The selected domain was not valid.
(11-16-2015, 03:37 AM)TGates Wrote: @[Me.B]. Any ideas? This is becoming a recurring issue...

(11-16-2015, 06:34 AM)Me.B Wrote: It should not and this seem related to new installer post 1.0.3? Upgrade tool?

We are supposed in 1.0.3 to use OLD 1.0 panel code branch and only patching here the FTP issue.

So a bit surprising, I notice the issue firstly reported with upgrades from ZPANEL.

My is a fresh install on Debian 8, not upgrade
Reply
Thanks given by:
#8
[Not Solved] RE: The selected domain was not valid.
i have taken my 2 modules that Works

just rename the 2 modules and place this 2


Attached Files
.zip   mailboxes.zip (Size: 14.94 KB / Downloads: 118)
.zip   sub_domains.zip (Size: 11.71 KB / Downloads: 113)
Sentora 1.0.3 on [Image: DO_Logo_Horizontal_Blue-3db19536.png]

-= Github =-  -= My Repo =-

My Modules
Reply
Thanks given by: TGates , lino69
#9
[Not Solved] RE: The selected domain was not valid.
(11-16-2015, 07:34 AM)Diablo925 Wrote: i have taken my 2 modules that Works

just rename the 2 modules and place this 2

Thanks Diablo925! This is a good temporary solution until we get the installer patched again Wink
-TGates - Head of Support

SEARCH the Forums or read the DOCUMENTATION before posting!
Modules Maintained: 13 - Module Installs: 108k+

Find my support or modules helpful? Donate HERE
Get your domains using my affiliate link:
GoDaddy - Domains
Reply
Thanks given by:
#10
[Not Solved] RE: The selected domain was not valid.
The root of this problem is in: /etc/sentora/panel/dryden/fs/director.class.php


PHP Code:
   static function CheckForEmptyValue($value) {
 
       if (!empty($value)) {
 
           return false;
 
       } else {
 
           return true;
 
       }
 
   

1.) practical problem
All the values that are ever passed to this function in mailboxes module (and others safe to presume) consist of TRUE or FALSE and are booleans so this function always satisfies the first criteria.

2.) logical and intuitive problem
For some strange reason there's a double negation here "if not empty than false" but it should return "true" if it aint empty for the intuitive part, or even better it should be "if empty than return false" for logic,

3.) becouse of this strange logic in (2) somebody made a mistake when adding domain validation code to: /panel/modules/mailboxes/code/controller.ext.php
PHP Code:
if (!self::IsValidEmail($fulladdress)) {
 
           self::$validemail true;
 
           return false;
 
       }
 if(!self::IsValidDomain($domain)){
 
           self::$validdomain true;
 
           return false;
 
       

as you can see in email validation part a negation is used again to compensate for the bad practice of negation and returning false mentioned in (2) furthermore inside the IsValidEmail it is compensated some more .. it's a mess. anyways whoever added domain validation followed the (no)logic and compensated with negation infront IsValidDomain function BUT this one doesnt comepnsate one more time inside the function so here comes the "the domain was not valid" error. Basically only if it is NOT valid domain the domain is valid boolean is set to TRUE/VALID while whenever the domain is really VALID it results to FALSE. 

A simple solution is to remove "!" from "if(!self::IsValidDomain($domain))" and it will work in all modules where the check is performed.
Next release would be better off refactoring the core functions and logic.
Reply
Thanks given by:


Possibly Related Threads...
Thread Author Replies Views Last Post
Sentora was installed on my main domain? Bloodcon 1 214 11-30-2017, 08:17 PM
Last Post: Me.B
Host domain but not email Silverbug 1 157 10-31-2017, 08:00 AM
Last Post: Me.B
Change Top Level Sentora Domain rsthomas 3 306 10-25-2017, 02:34 AM
Last Post: TGates

Forum Jump:


Users browsing this thread: 1 Guest(s)